Puppet: System Administration Automated

Support

Ticket #1040 (closed enhancement: fixed)

Opened 10 months ago

Last modified 9 months ago

Exceptions when compiling should include node name

Reported by: luke Assigned to: luke
Priority: normal Milestone: 0.24.2
Component: server Version:
Severity: normal Keywords: exceptions,server
Cc: Triage Stage: Ready for checkin
Attached Patches: Code Complexity: Medium

Description

The subject says it all -- the node name should be included in all exceptions generated on the server.

Change History

02/18/08 11:30:30 changed by jamtur01

Every exception? or when compiling? Because compiler.rb seems to return the node name most of the time...

02/18/08 16:14:08 changed by luke

In looking through the compiler.rb, there are still quite a few errors that don't return a node name.

My guess is that if you just trapped exceptions in Interpreter#compile, and tacked the node name on, you'd get 99% of the cases.

02/19/08 02:24:32 changed by jamtur01

  • owner changed from community to luke.
  • stage changed from Accepted to Ready for checkin.
  • patch changed from None to Code.

Fixed (maybe) in commit [d82bfd86288cc012018797d98168f918bff75778] in branch 0.24.x.

02/19/08 05:43:29 changed by jamtur01

Second commit [1f0ea5a0e8629f0ff281153d710ef9e75bee3134] - adds more detail and backtrace option - also in branch 0.24.x

02/20/08 01:15:30 changed by jamtur01

Test fixed in commit [f006e177ec366638b7df6b271edb4650bf2b7705] in branch 0.24.x

02/20/08 01:26:13 changed by luke

  • status changed from new to closed.
  • resolution set to fixed.

02/25/08 01:52:25 changed by jamtur01

  • status changed from closed to reopened.
  • resolution deleted.

Fix was incorrect - raise was before backtrace - backtrace would never have been executed.

Fixed in commit [c8b320e36652db5dac02870ecc73a62c70d5c736] in branch 0.24.x

02/25/08 01:52:35 changed by jamtur01

  • status changed from reopened to new.

02/25/08 03:47:52 changed by luke

  • status changed from new to closed.
  • resolution set to fixed.

Pushed.