Puppet: System Administration Automated

Support

Ticket #1117 (closed defect: worksforme)

Opened 9 months ago

Last modified 9 months ago

Puppetmaster w/ Mongrel barfs when clients lack PTR records

Reported by: pawalls Assigned to: community
Priority: normal Milestone: 0.24.3
Component: library Version: 0.24.2
Severity: normal Keywords: mongrel
Cc: Triage Stage: Unreviewed
Attached Patches: Code Complexity: Trivial

Description

I'm not sure if this was intentional or not, but adding a simple rescue block around the Resolv portion results in my clients being able to do a completely successful Puppet run. Patch attached.

Attachments

puppet_fix_mongrel_without_ptr.2.diff (0.6 kB) - added by pawalls on 03/07/08 03:16:11.
Patch to add begin/rescue block around offending code

Change History

03/07/08 03:16:11 changed by pawalls

  • attachment puppet_fix_mongrel_without_ptr.2.diff added.

Patch to add begin/rescue block around offending code

03/07/08 03:18:25 changed by pawalls

I probably should have specified a particular exception in the rescue block. I'm not sure what Resolv throws and I don't have the time to find out right now. Hopefully the attached patch is sufficient.

03/07/08 03:18:34 changed by pawalls

  • milestone set to 0.24.3.

03/07/08 03:18:46 changed by pawalls

  • complexity changed from Unknown to Trivial.

03/07/08 06:46:22 changed by andrew

  • status changed from new to closed.
  • resolution set to worksforme.

This is fixed

commit 7a9aae84805e415de090f0ce9be04beb8435e117 Author: Luke Kanies <luke@madstop.com> Date: Sat Jan 19 14:08:44 2008 -0600

Wrapping the Resolv call in the mongrel server so if it fails it doesn't kill the server.