Puppet: System Administration Automated

Support

Ticket #1158 (closed defect: duplicate)

Opened 8 months ago

Last modified 8 months ago

Regression introduced by [388cf7c]

Reported by: ctrlaltdel Assigned to: community
Priority: normal Milestone:
Component: server Version: 0.24.3
Severity: normal Keywords: facts fqdn domain regression
Cc: francois@ctrlaltdel.ch Triage Stage: Unreviewed
Attached Patches: None Complexity: Unknown

Description

The fact domain is always empty and fqdn contains only the hostname after applying commit [388cf7c]

In lib/puppet/network/handler/master.rb, we have

           # Always use the hostname from Facter.
            client = facts["hostname"]
            clientip = facts["ipaddress"]
            if Puppet[:node_name] == 'cert'
                if name
                    facts["fqdn"] = client
                    facts["hostname"], facts["domain"] = client.split('.', 2)
                    client = name

which is equivalent to

facts["fqdn"] = facts["hostname"]

which is wrong.

Change History

03/26/08 16:46:59 changed by ctrlaltdel

  • component changed from library to server.

03/26/08 17:50:42 changed by ctrlaltdel

  • status changed from new to closed.
  • resolution set to duplicate.

This ticket a duplicate of #1137 but the fix was only commited in origin/0.24.x but not in origin/master.