service provider on Debian doesn't realize a service is disabled

This is a Red Hat bug: https://bugzilla.redhat.com/show_bug.cgi?id=430882

I just asked RH support (again!) when it's going to be fixed.

Ha! Sorry. You said Debain :)

Okay this was annoying - and I'll say it again update-rc.d suck arse.

Okay - what Puppet does to check if a service is enabled is:

def enabled?
        output = update "-n", "-f", @resource[:name], "remove"

        # If it's enabled, then it will print output showing removal of
        # links.
        if output =~ /etc\/rc[\dS].d\/S|not installed/
            return :true
        else
            return :false
        end

So essentially it runs:

update-rc.d -n -f servicename remove

If it returns either "not installed" or a list of links to be removed then it's set to "true". Hmmm not sure about that "not installed" but okay. But when a service is disabled using the updated method in #1060 this now returns the K00 links - which results in Puppet thinking the service is enabled when it is in fact ... not.

To fix this I've told Puppet to only assume a service is enabled if the update-rc.d -n -f servicename remove command returns one or more links prefixed with S. If the command returns links with only K prefixes Puppet now knows the service is actually disabled.

Now that logic makes sense to me... can everyone confirm they also feel warm and fuzzy about this?

The fix is in commit [2036d22cfa950ed84957427b98f69c1719b64dd7] in branch 0.24.x

This seems like a reasonable fix to me, but I'm no Debian hero.

Pushed.

Sounds like the right fix to me.

Merged and pushed last week.