Puppet: System Administration Automated

Support

Ticket #1237 (new defect)

Opened 6 months ago

Last modified 6 months ago

RSpec tests do not work when Mongrel is not available.

Reported by: porridge Assigned to: luke
Priority: normal Milestone:
Component: testing Version:
Severity: normal Keywords: mongrel rspec
Cc: Triage Stage: Needs design decision
Attached Patches: Tests Complexity: Unknown

Description

If you try, you get errors such as: 

/home/porridge/Desktop/coding/puppet-git/spec/../lib/puppet/network/http/mongrel/rest.rb:3: uninitialized constant Mongrel (NameError)
        from /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in `gem_original_require'
        from /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in `require'
        from /home/porridge/Desktop/coding/puppet-git/spec/../lib/puppet/network/http/mongrel.rb:3
        from /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in `gem_original_require'
        from /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in `require'
        from /home/porridge/Desktop/coding/puppet-git/spec/../lib/puppet/network/http.rb:13
        from /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in `gem_original_require'
        from /usr/lib/ruby/1.8/rubygems/custom_require.rb:27:in `require'
        from /home/porridge/Desktop/coding/puppet-git/spec/unit/network/http/mongrel.rb:7
        from /home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec/runner/example_group_runner.rb:14:in `load'
        from /home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec/runner/example_group_runner.rb:14:in `load_files'
        from /home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec/runner/example_group_runner.rb:13:in `each'
        from /home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec/runner/example_group_runner.rb:13:in `load_files'
        from /home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec/runner/options.rb:85:in `run_examples'
        from /home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec.rb:20:in `run'
        from /home/porridge/Desktop/coding/puppet-git/lib/../vendor/gems/rspec/lib/spec/runner.rb:192:in `register_at_exit_hook'

I'm about to make a patch available in my git repository.

Attachments

0001-Made-inclusion-or-evaluation-of-the-pieces-of-code-d.patch (3.7 kB) - added by porridge on 05/20/08 21:25:49.
patch

Change History

05/20/08 21:25:14 changed by porridge

  • patch changed from None to Tests.

You should be able to get a patch for this from "fix-1237" branch of my git repository:

http://reductivelabs.com/trac/puppet/wiki/DeveloperRepositories#marcin-owsiany

Attaching the diff for convenience.

05/20/08 21:25:49 changed by porridge

  • attachment 0001-Made-inclusion-or-evaluation-of-the-pieces-of-code-d.patch added.

patch

05/22/08 08:05:31 changed by jamtur01

  • owner changed from community to luke.
  • stage changed from Unreviewed to Needs design decision.

Is this the right approach to this? Is this sort of a hack'ish approach? Luke?

05/22/08 11:05:14 changed by porridge

See also #1259 for a related, but different problem (there the tests at least load, but fail).