Puppet: System Administration Automated

Support

Ticket #982 (closed defect: fixed)

Opened 11 months ago

Last modified 11 months ago

Cycles aren't caught when inappropriate start vertices are used

Reported by: luke Assigned to: luke
Priority: normal Milestone:
Component: library Version: 0.24.1
Severity: blocker Keywords: graph, sort
Cc: Triage Stage: Accepted
Attached Patches: None Complexity: Unknown

Description

This is painfully difficult to reproduce, because the start vertex is basically determined from hashing, but I've reproduced it enough (largely in the test/other/transaction.rb file, in the test_fail_on_cycle test) that I know it's a problem.

If we specify the right start vertex, everything works, but if we get it wrong, then back edges aren't correctly caught. Looks like it's time to remove the last vestiges of GRATR.

Change History

01/08/08 02:26:09 changed by luke

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in [40addcd1920b0fa2f558c415e65ea665bac812f9], and as predicted, I removed GRATR entirely in this commit.